From 16461ce7d8346b0183f2b0d8d3b064d23cadd0d1 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Mon, 24 Apr 2006 03:29:27 +0000 Subject: [PATCH] Check for invalid serialized objects and return an error condition instead of just dying. --- includes/Revision.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/includes/Revision.php b/includes/Revision.php index c289bf784e..e9083a7742 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -530,6 +530,11 @@ class Revision { if( in_array( 'object', $flags ) ) { # Generic compressed storage $obj = unserialize( $text ); + if ( !is_object( $obj ) ) { + // Invalid object + wfProfileOut( $fname ); + return false; + } $text = $obj->getText(); } -- 2.20.1